From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/proxmox-mail-forward 0/2] install proxmox-mail-forward at /usr/libexec
Date: Mon, 7 Jul 2025 12:45:08 +0200 (CEST) [thread overview]
Message-ID: <1035168769.2761.1751885108695@webmail.proxmox.com> (raw)
In-Reply-To: <20250625122012.226237-1-l.wagner@proxmox.com>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
although the comment in the postinst (that got moved over)
could be shortened to just say that the entry is unconditionally
rewritten, IMHO ;)
> Lukas Wagner <l.wagner@proxmox.com> hat am 25.06.2025 14:20 CEST geschrieben:
>
>
> proxmox-mail-forward is not intended to be called by regular users, so
> installing it at /usr/libexec/proxmox-mail-forward is a better fit.
>
> pve-manager:
>
> Lukas Wagner (1):
> d/postinst: remove old pvemailforward migration logic
>
> debian/postinst | 10 ----------
> 1 file changed, 10 deletions(-)
>
>
> proxmox-mail-forward:
>
> Lukas Wagner (1):
> install to /usr/libexec instead of /usr/bin
>
> Makefile | 2 --
> debian/lintian-overrides | 2 +-
> debian/proxmox-mail-forward.postinst | 13 ++++++++++---
> debian/rules | 9 ++++++++-
> 4 files changed, 19 insertions(+), 7 deletions(-)
>
>
> Summary over all repositories:
> 5 files changed, 19 insertions(+), 17 deletions(-)
>
> --
> Generated by git-murpp 0.8.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-07 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 12:20 Lukas Wagner
2025-06-25 12:20 ` [pve-devel] [PATCH manager 1/1] d/postinst: remove old pvemailforward migration logic Lukas Wagner
2025-06-25 12:20 ` [pve-devel] [PATCH proxmox-mail-forward 1/1] install to /usr/libexec instead of /usr/bin Lukas Wagner
2025-07-07 10:45 ` Fabian Grünbichler [this message]
2025-07-16 7:41 ` [pve-devel] superseded: [PATCH manager/proxmox-mail-forward 0/2] install proxmox-mail-forward at /usr/libexec Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1035168769.2761.1751885108695@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox