From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH common] schema: explicitly set min/max for vmid option
Date: Fri, 16 Jun 2023 12:40:37 +0200 [thread overview]
Message-ID: <10334147-c485-9f9f-5ad9-e822c4c339f7@proxmox.com> (raw)
In-Reply-To: <9789e9af-dc35-3ee5-fb96-148fc0b8b3f5@proxmox.com>
Am 16/06/2023 um 11:01 schrieb Fiona Ebner:
>> let's see if we ever used values < 100 as some special thingy somwhere 😜
>> (if, those things should probably just switch to another format)
>
> Even if, the problem is limited to cases where the format verification
> wouldn't be done, but the min/max limits would apply. Can that even happen?
I really don't expect it, would need to manually extract the API schema
from the format and then use that to parse something – especially for such
simple formats (i.e., no format string composed of multiple properties)
I'd find that highly surprising; just saw a bit odd (perl) code already
to dare to rule the possibility of this out ;-)
prev parent reply other threads:[~2023-06-16 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 7:35 [pve-devel] " Fiona Ebner
2023-06-16 8:23 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-16 9:01 ` Fiona Ebner
2023-06-16 10:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10334147-c485-9f9f-5ad9-e822c4c339f7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox