Re: [PATCH pve-network 07/13] api2: add route map entry module

[Stefan Hanreich <s.hanreich@proxmox.com>]

On 3/26/26 4:12 PM, Hannes Laimer wrote:
> On 2026-03-25 10:49, Stefan Hanreich wrote:
>> This module contains the following API endpoints:
>>
>> GET /route-maps/<id>/<order> - gets the order'th entry in route map
>> <id>
>> PUT /route-maps/<id>/<order> - updates the order'th entry in
>> route map <id>
>> DELETE /route-maps/<id>/<order> - deletes the order'th
>> entry in route map <id>
>>
>> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
>> ---
> 
> [..]
> 
>> +__PACKAGE__->register_method({
>> +    name => 'update_route_map_entry',
>> +    path => '',
>> +    method => 'PUT',
>> +    permissions => {
>> +        check => ['perm', '/sdn/route-maps/{route-map-id}', ['SDN.Allocate']],
>> +    },
>> +    description => "Update Route Map Entry",
>> +    parameters => {
>> +        properties => {
>> +            digest => get_standard_option('pve-config-digest'),
>> +            'lock-token' => get_standard_option('pve-sdn-lock-token'),
>> +            PVE::Network::SDN::RouteMaps::route_map_properties(1)->%*,
>> +        },
>> +    },
>> +    returns => {
>> +        type => "null",
>> +    },
>> +    code => sub {
>> +        my ($param) = @_;
>> +
>> +        my $lock_token = extract_param($param, 'lock-token');
>> +
>> +        PVE::Network::SDN::lock_sdn_config(
>> +            sub {
>> +                my $config = PVE::Network::SDN::RouteMaps::config();
>> +
>> +                my $digest = extract_param($param, 'digest');
>> +                PVE::Tools::assert_if_modified($config->digest(), $digest) if $digest;
>> +
>> +                my $route_map_id = extract_param($param, 'route-map-id');
>> +                my $order = extract_param($param, 'order');
>> +                my $delete = extract_param($param, 'delete');
>> +
>> +                $config->update($route_map_id, $order, $param);
> 
> looks like the update call is missing the `.. , $delete);`

good catch, fixed