public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] setup/centos: set /etc/locale.conf to avoid systemd-firstboot hanging
Date: Tue, 24 Aug 2021 13:27:42 +0200	[thread overview]
Message-ID: <0f889955-a44d-0c0d-bbc5-f8ecfd78d2e2@proxmox.com> (raw)
In-Reply-To: <20210824100741.976738-1-o.bektas@proxmox.com>

On 24/08/2021 12:07, Oguz Bektas wrote:
> we can set the locale to a sane default to avoid the issue described in
> forum post [0]
> 
> [0]: https://forum.proxmox.com/threads/centos-lxc-containers-require-a-reboot.94972/
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  src/PVE/LXC/Setup/CentOS.pm | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
> index 77eb6f7..fa8f862 100644
> --- a/src/PVE/LXC/Setup/CentOS.pm
> +++ b/src/PVE/LXC/Setup/CentOS.pm
> @@ -110,6 +110,10 @@ sub template_fixup {
>  	$data =~ s!^(/sbin/start_udev.*)$!#$1!gm;
>  	$self->ct_file_set_contents($filename, $data);
>      }
> +
> +    # temporary fix for systemd-firstboot
> +    $self->ct_file_set_contents('/etc/locale.conf', "LANG=C.utf8");
> +

really should not be done if the file already exists/contains options though?
Else you potentially override customized templates, which is not nice.

>      # always call so root can login, if /etc/securetty doesn't exists it's a no-op
>      $self->setup_securetty($conf);
>  }
> 





      reply	other threads:[~2021-08-24 11:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 10:07 Oguz Bektas
2021-08-24 11:27 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f889955-a44d-0c0d-bbc5-f8ecfd78d2e2@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal