public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH cluster] datacenter config: document that the migration network affects replications
@ 2025-05-19 12:25 Maximiliano Sandoval
  2025-05-20 12:34 ` [pve-devel] applied: " Fiona Ebner
  2025-06-02 12:56 ` [pve-devel] " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2025-05-19 12:25 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/DataCenterConfig.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
index a3db78e..205b784 100644
--- a/src/PVE/DataCenterConfig.pm
+++ b/src/PVE/DataCenterConfig.pm
@@ -44,7 +44,7 @@ my $migration_format = {
 	optional => 1,
 	type => 'string', format => 'CIDR',
 	format_description => 'CIDR',
-	description => "CIDR of the (sub) network that is used for migration."
+	description => "CIDR of the (sub) network that is used for migration and replication."
     },
 };
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH cluster] datacenter config: document that the migration network affects replications
  2025-05-19 12:25 [pve-devel] [PATCH cluster] datacenter config: document that the migration network affects replications Maximiliano Sandoval
@ 2025-05-20 12:34 ` Fiona Ebner
  2025-06-02 12:56 ` [pve-devel] " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2025-05-20 12:34 UTC (permalink / raw)
  To: pve-devel, Maximiliano Sandoval


Applied, thanks!

[1/1] datacenter config: document that the migration network affects replications
      commit: a042611c9d06ea24d02423387005fa97319f9f2e


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH cluster] datacenter config: document that the migration network affects replications
  2025-05-19 12:25 [pve-devel] [PATCH cluster] datacenter config: document that the migration network affects replications Maximiliano Sandoval
  2025-05-20 12:34 ` [pve-devel] applied: " Fiona Ebner
@ 2025-06-02 12:56 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-06-02 12:56 UTC (permalink / raw)
  To: Proxmox VE development discussion, Maximiliano Sandoval

Am 19.05.25 um 14:25 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/PVE/DataCenterConfig.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index a3db78e..205b784 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -44,7 +44,7 @@ my $migration_format = {
>  	optional => 1,
>  	type => 'string', format => 'CIDR',
>  	format_description => 'CIDR',
> -	description => "CIDR of the (sub) network that is used for migration."
> +	description => "CIDR of the (sub) network that is used for migration and replication."
>      },
>  };
>  

good to describe the status quo, but that status is not really ideal, might
be worth to add a dedicated setting for this outside of the "migration"
property. Upcoming PVE 9 would be a good choice for this, as then we could
output a notice for the case that the migration network is configured and
there are existing replication jobs defined,


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-06-02 12:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-19 12:25 [pve-devel] [PATCH cluster] datacenter config: document that the migration network affects replications Maximiliano Sandoval
2025-05-20 12:34 ` [pve-devel] applied: " Fiona Ebner
2025-06-02 12:56 ` [pve-devel] " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal