From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox
Date: Mon, 22 Apr 2024 15:11:04 +0200 [thread overview]
Message-ID: <0f77e682-8177-472b-907f-b1f18be745d3@proxmox.com> (raw)
In-Reply-To: <20240415085002.665246-1-m.frank@proxmox.com>
Am 15.04.24 um 10:50 schrieb Markus Frank:
> Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a VM.
> If i440fx is selected, another ComboBox will be enabled/visible that does not
> have the Intel option, as Intel-vIOMMU is not compatible with i440fx.
>
Just wondering, is it possible to bind the comboItems instead of having
two different comboboxes?
Should we display some hint that Intel can/should also be used even if
you have an AMD? Maybe even just in the text we display, like "Intel
(also used for AMD)" but hope somebody can come up with something better.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-04-22 13:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 8:50 Markus Frank
2024-04-15 8:50 ` [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings Markus Frank
2024-04-22 13:13 ` Fiona Ebner
2024-04-22 13:18 ` Dominik Csapak
2024-04-22 13:19 ` Fiona Ebner
2024-04-22 13:21 ` Thomas Lamprecht
2024-04-22 13:22 ` Dominik Csapak
2024-04-22 13:11 ` Fiona Ebner [this message]
2024-04-22 13:16 ` [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox Dominik Csapak
2024-04-22 13:24 ` Fiona Ebner
2024-04-22 17:58 ` Thomas Lamprecht
2024-04-22 13:11 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f77e682-8177-472b-907f-b1f18be745d3@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox