Re: [pve-devel] [PATCH qemu-server 2/8] config to command: add one '-global' option for each flag

[Fiona Ebner <f.ebner@proxmox.com>]

Am 06.03.25 um 11:44 schrieb Dominik Csapak:
> If we have multiple 'globalFlags', we have to encode each one separately
> on the commandline with '-global OPTION', since QEMU does not allow to
> have multiple options here.
> 
> We currently only have one such flag that used the 'globalFlags' list,
> so it never popped up. (All other uses directly add an option to the
> commandline)
> 
> Avoid future bugs by fixing it now.
> 

So there is no real point to collecting the flags in the first place?
I.e. we could also get rid of the variable and have the single current
user of the variable add the flag directly on the commandline too. Or
otherwise, we could change the other users and collect all flags with
this variable. Pre-existing of course, but ideally, we could avoid the
mishmash.

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
>  PVE/QemuServer.pm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index b6fc1f17..13af495d 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -4001,7 +4001,9 @@ sub config_to_command {
>      push @$cmd, @$devices;
>      push @$cmd, '-rtc', join(',', @$rtcFlags) if scalar(@$rtcFlags);
>      push @$cmd, '-machine', join(',', @$machineFlags) if scalar(@$machineFlags);
> -    push @$cmd, '-global', join(',', @$globalFlags) if scalar(@$globalFlags);
> +    for my $flag ($globalFlags->@*) {
> +	push @$cmd, '-global', $flag;
> +    }
>  
>      if (my $vmstate = $conf->{vmstate}) {
>  	my $statepath = PVE::Storage::path($storecfg, $vmstate);



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel