From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager 0/2] fix ceph version handling in gui
Date: Wed, 10 Nov 2021 14:40:22 +0100 [thread overview]
Message-ID: <0d2e49ca-e68f-1f22-eaa9-d03055e1053c@proxmox.com> (raw)
In-Reply-To: <20211110121556.500448-1-d.csapak@proxmox.com>
On 10.11.21 13:15, Dominik Csapak wrote:
> we removed the broadcast of the legacy kv 'ceph-version', but our
> gui and api were not completely adapted to the new versions yet
> (it seems we forgot)
>
> the ui patch fixes the dashboard and service lists, but the osd panel
> is still broken (that needs the api patch)
>
> alternatively to the api patch, we could revert fb0cb9b7, but
> as we already rolled that change out to pve-no-subscription,
> i see no point to it really.
>
>
> Dominik Csapak (2):
> api: ceph: fix getting ceph versions
> ui: ceph: fix version handling
>
> PVE/API2/Ceph/OSD.pm | 5 ++---
> PVE/API2/Cluster/Ceph.pm | 5 +----
> www/manager6/ceph/OSD.js | 6 +++---
> www/manager6/ceph/Services.js | 8 ++++----
> www/manager6/ceph/StatusDetail.js | 8 ++++----
> 5 files changed, 14 insertions(+), 18 deletions(-)
>
applied series and reverted fb0cb9b7 for now, we should be able to remove with
8.0 (or sooner, it's not _that_ hard of a break) thanks!
prev parent reply other threads:[~2021-11-10 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 12:15 [pve-devel] " Dominik Csapak
2021-11-10 12:15 ` [pve-devel] [PATCH manager 1/2] api: ceph: fix getting ceph versions Dominik Csapak
2021-11-10 12:15 ` [pve-devel] [PATCH manager 2/2] ui: ceph: fix version handling Dominik Csapak
2021-11-10 12:58 ` [pve-devel] [PATCH manager 0/2] fix ceph version handling in gui Thomas Lamprecht
2021-11-10 13:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d2e49ca-e68f-1f22-eaa9-d03055e1053c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox