From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-zsync] parse disks: improve error messages
Date: Wed, 13 Sep 2023 13:24:25 +0200 [thread overview]
Message-ID: <0d0fd3e4-f4e6-47d4-bf4a-542faabedc40@proxmox.com> (raw)
In-Reply-To: <CVGXKPR6G13G.12F592ZB3AE39@erna>
Am 12/09/2023 um 14:18 schrieb Stefan Sterz:
> On Tue Sep 12, 2023 at 11:31 AM CEST, Fiona Ebner wrote:
>> The one with the backup flag was reported in the community forum:
>> https://forum.proxmox.com/threads/77254/
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>> pve-zsync | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/pve-zsync b/pve-zsync
>> index 98190b2..0e48865 100755
>> --- a/pve-zsync
>> +++ b/pve-zsync
>> @@ -949,11 +949,12 @@ sub parse_disks {
>> $num++;
>>
>> } else {
>> - die "ERROR: in path\n";
>> + die "unexpected path '$path'\n";
>> }
>> }
>>
>> - die "Vm include no disk on zfs.\n" if !$disks->{0};
>> + die "guest does not include any ZFS volumes (or all excluded by the backup flag).\n"
> small nit: "guest" should be capitalized if this is the beginning of a
> sentence.
The more common variant in our code base is starting error messages
with lower case though, but I did not care to much to enforce it
most of the time where I got one starting with a capital letter.
prev parent reply other threads:[~2023-09-13 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 9:31 Fiona Ebner
2023-09-12 12:18 ` Stefan Sterz
2023-09-13 11:24 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d0fd3e4-f4e6-47d4-bf4a-542faabedc40@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox