From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: fix duplicate references when using multiple DiskStorageSelectors
Date: Tue, 6 Jun 2023 17:09:42 +0200 [thread overview]
Message-ID: <0cd912f9-8e98-e004-28cb-80b4f3a3ed5e@proxmox.com> (raw)
In-Reply-To: <20230321132711.3377257-1-d.csapak@proxmox.com>
Am 21/03/2023 um 14:27 schrieb Dominik Csapak:
> by removing the references and change the one place where we used
> one of the references.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> while i tested all places where we have a disk selector
> (wizard, clone, efidisk, add hd) i am not super sure i found all uses
> i grepped after the references, and only found one use where we used it
> in a lookup/lookupReference, but maybe someone else too can check that
> everything still works...
>
>
> www/manager6/form/DiskStorageSelector.js | 4 ----
> www/manager6/window/Clone.js | 2 +-
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-06-06 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 13:27 [pve-devel] " Dominik Csapak
2023-06-06 15:09 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cd912f9-8e98-e004-28cb-80b4f3a3ed5e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox