From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server 1/2] qmeventd: improve getting vmid from PID in presence of legacy cgroup entries
Date: Mon, 10 Jul 2023 10:20:08 +0200 [thread overview]
Message-ID: <0c6d1b85-ba97-de7a-12f5-4108f1070d2c@proxmox.com> (raw)
In-Reply-To: <20230710075825.15882-1-f.ebner@proxmox.com>
Am 10.07.23 um 09:58 schrieb Fiona Ebner:
> On a hybrid cgroup system, the /proc/<PID>/cgroup file usually looks
> like:
>
>> 13:pids:/qemu.slice/110.scope
>> 12:perf_event:/
>> 11:devices:/qemu.slice
>> 10:misc:/
>> 9:hugetlb:/
>> 8:freezer:/
>> 7:cpu,cpuacct:/qemu.slice/110.scope
>> 6:memory:/qemu.slice/110.scope
>> 5:rdma:/
>> 4:cpuset:/
>> 3:blkio:/qemu.slice
>> 2:net_cls,net_prio:/
>> 1:name=systemd:/qemu.slice/110.scope
>> 0::/qemu.slice/110.scope
>
> but after 'umount /sys/fs/cgroup/pids' or for other reasons, it could
> happen that an entry like '11:devices:/qemu.slice' is the first to
> match the '/qemu.slice' part, which previously made the code expect to
> find the VMID.
>
> To improve detection, as a first step, match the trailing slash too.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/129320/post-571654
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
I'll send a v2 with a bit more. Sorry for the noise.
prev parent reply other threads:[~2023-07-10 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 7:58 Fiona Ebner
2023-07-10 7:58 ` [pve-devel] [PATCH qemu-server 2/2] qmeventd: further improve getting vmid from PID Fiona Ebner
2023-07-10 8:20 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c6d1b85-ba97-de7a-12f5-4108f1070d2c@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox