From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Severen Redwood <severen.redwood@sitehost.co.nz>,
pve-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH container v2] api: record CT ID as used after a container is destroyed
Date: Thu, 31 Oct 2024 18:27:43 +0100 [thread overview]
Message-ID: <0c3fcb3d-6367-403b-968a-d73042853c33@proxmox.com> (raw)
In-Reply-To: <20241004050957.441759-4-severen.redwood@sitehost.co.nz>
This is missing a
use PVE::UsedVmidList;
at the top of the file. Otherwise running
pct destroy {vmid}
will result in the following error:
Undefined subroutine &PVE::UsedVmidList::add_vmid called at
/usr/share/perl5/PVE/API2/LXC.pm line 799.
This doesn't seem to be necessary in the qemu-server repo, but I did not
investigate further how pulling in dependencies works there.
On 2024-10-04 07:07, Severen Redwood wrote:
> After a container is destroyed, record that its ID has been used via the
> `PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can
> later optionally avoid suggesting previously used IDs.
>
> Co-authored-by: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
> Signed-off-by: Severen Redwood <severen.redwood@sitehost.co.nz>
> ---
> src/PVE/API2/LXC.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index 918e719..ee0e3e9 100644
> --- a/src/PVE/API2/LXC.pm
> +++ b/src/PVE/API2/LXC.pm
> @@ -794,7 +794,9 @@ __PACKAGE__->register_method({
> }
> }
>
> - # only now remove the zombie config, else we can have reuse race
> + # only now mark the CT ID as previously used and remove the zombie
> + # config, else we can have reuse race
> + PVE::UsedVmidList::add_vmid($vmid);
> PVE::LXC::Config->destroy_config($vmid);
> };
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-10-31 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241004050957.441759-1-severen.redwood@sitehost.co.nz>
2024-10-04 5:07 ` [pve-devel] [PATCH manager v2 1/2] close #4369: api: optionally only suggest unique IDs Severen Redwood via pve-devel
2024-10-04 5:07 ` [pve-devel] [PATCH manager v2 2/2] close #4369: ui: add datacenter option for unique VM/CT IDs Severen Redwood via pve-devel
2024-10-04 5:07 ` [pve-devel] [PATCH container v2] api: record CT ID as used after a container is destroyed Severen Redwood via pve-devel
2024-10-04 5:07 ` [pve-devel] [PATCH qemu-server v2] api: record VM ID as used after a virtual machine " Severen Redwood via pve-devel
2024-10-04 5:07 ` [pve-devel] [PATCH cluster v2 5/6] cluster files: add used_vmids.list Severen Redwood via pve-devel
2024-10-04 5:07 ` [pve-devel] [PATCH cluster v2 6/6] datacenter config: add unique-next-id to schema Severen Redwood via pve-devel
2024-10-30 2:29 ` [pve-devel] [PATCH SERIES v2] Add ability to prevent suggesting previously used VM/CT IDs Severen Redwood via pve-devel
[not found] ` <20241004050957.441759-2-severen.redwood@sitehost.co.nz>
2024-10-31 13:10 ` [pve-devel] [PATCH manager v2 1/2] close #4369: api: optionally only suggest unique IDs Aaron Lauterer
[not found] ` <20241004050957.441759-4-severen.redwood@sitehost.co.nz>
2024-10-31 17:27 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c3fcb3d-6367-403b-968a-d73042853c33@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=severen.redwood@sitehost.co.nz \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox