From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Friedrich Weber" <f.weber@proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] lvm: avoid warning due to human-readable text in vgs output
Date: Fri, 12 Jan 2024 16:45:05 +0100 [thread overview]
Message-ID: <0c29c04e-65d6-4ffe-8e51-26a5a89064f8@proxmox.com> (raw)
In-Reply-To: <5fcfc2d8-ec48-48a2-9262-31c3635e09a5@proxmox.com>
Am 12.01.24 um 16:11 schrieb Friedrich Weber:
> On 12/01/2024 11:28, Fabian Grünbichler wrote:
>>> The vgs message is printed to stdout, so we could do something like
>>>
>>> warn $line if !defined($size);
>>>
>>> ?
>>
>> yep, that would be an option (warn+return ;))
>
> Right, thanks. Thinking about this some more, printing a user-visible
> warning sounds more sensible than suppressing the warning complete
> (either by passing `-qq` or ignoring the line, as in the current patch).
> I'll send a v2.
If we go for the warn route, please prefix the line appropriately. This
is in a function rather deep down that's executed during various
different top-level operations, so it should be made clear where it
comes from.
prev parent reply other threads:[~2024-01-12 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 16:58 Friedrich Weber
2024-01-12 8:57 ` Fiona Ebner
2024-01-12 9:09 ` Friedrich Weber
2024-01-12 9:30 ` Fiona Ebner
2024-01-12 9:22 ` Fabian Grünbichler
2024-01-12 10:06 ` Friedrich Weber
2024-01-12 10:28 ` Fabian Grünbichler
2024-01-12 15:11 ` Friedrich Weber
2024-01-12 15:45 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c29c04e-65d6-4ffe-8e51-26a5a89064f8@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox