From: Dominik Csapak <d.csapak@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Philipp Hufnagl" <p.hufnagl@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v7 0/2] fix #4849: allow download of compressed ISOs
Date: Wed, 20 Sep 2023 13:54:42 +0200 [thread overview]
Message-ID: <0bc30d40-6444-44d6-8161-7218c0d4957b@proxmox.com> (raw)
In-Reply-To: <b4c34880-c3c9-43af-b2ed-5040558eea31@proxmox.com>
On 9/20/23 13:50, Dominik Csapak wrote:
> On 9/20/23 13:46, Fabian Grünbichler wrote:
>> On September 20, 2023 1:07 pm, Dominik Csapak wrote:
>>> LGTM and works as advertised.
>>
>> it breaks downloading container templates that are compressed with one
>> of the "known" compression algorithms (such as gz).
>>
>> probably the detect-compression parameter and handling needs to go back
>> in (that was the reason it was there in the first place!), or some other
>> solution needs to be found..
>>
>>
>
> ah yes ofc, sorry for the oversight
>
> couldn't we simply check in the backend for the download for the content type?
> as we only really need to unpack isos?
>
>
ah no that also does not work.
so you're right, having a parameter that controls this is probably best
next prev parent reply other threads:[~2023-09-20 11:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 13:56 Philipp Hufnagl
2023-09-11 13:56 ` [pve-devel] [PATCH manager v7 1/2] fix #4849: api: download to storage: automatically dectect and configure compression Philipp Hufnagl
2023-09-11 13:56 ` [pve-devel] [PATCH manager v7 2/2] fix #4849: ui: " Philipp Hufnagl
2023-09-20 11:07 ` [pve-devel] [PATCH manager v7 0/2] fix #4849: allow download of compressed ISOs Dominik Csapak
2023-09-20 11:46 ` Fabian Grünbichler
2023-09-20 11:50 ` Dominik Csapak
2023-09-20 11:54 ` Dominik Csapak [this message]
2023-09-20 12:09 ` Fabian Grünbichler
2023-09-20 13:12 ` Philipp Hufnagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc30d40-6444-44d6-8161-7218c0d4957b@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox