From: Hannes Laimer <h.laimer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] ui: ha: consider status/presence of qdevice for warning
Date: Mon, 15 Sep 2025 12:29:31 +0200 [thread overview]
Message-ID: <0b417eea-4ccd-4495-bce5-fe9855ef9350@proxmox.com> (raw)
In-Reply-To: <ac50803f-c0d0-4e46-9a1b-c85e3c317283@proxmox.com>
On 15.09.25 12:25, Thomas Lamprecht wrote:
> Am 15.09.25 um 08:51 schrieb Hannes Laimer:
>> On 12.09.25 18:36, Thomas Lamprecht wrote:
>>> Am 12.09.25 um 12:17 schrieb Hannes Laimer:
>>>> We showed this warning for setups with two nodes and a qdevice, but for
>>>> setups like this this warning didn't make Sense. This checks if a
>>>> qdevice is connected to the cluster before showing the 'not enough votes
>>>> for reliable HA'-warning.
>>>
>>> Maybe it would be a bit more robust if we fleece that info in already in
>>> the backend – but disclaimer: I did not just check, so you really need
>>> to evaluate if it indeed makes sense or if applying this now as is might
>>> be the better route forward.
>>>
>>
>> I did consider that, but the `/cluster/config/nodes` endpoint seems to
>> really only be intended for actual corosync nodes, it is also used like
>> that. We could maybe add a `include-qdevice`-flag, but I think that
>> would seem rather out-of-place
>> ```
>> {
>> "name": "qClusterN1",
>> "node": "qClusterN1",
>> "nodeid": "1",
>> "quorum_votes": "1",
>> "ring0_addr": "192.168.55.44"
>> },
>> ```
>> is what it currently returns, none of those fields except name(?) would
>> really make sense for a qdevice.
>
> True, if, that would better fit in a new status endpoint there,
> but I see no hard need for creating such a endpoint just for
> this check now.
That's what I meant :) so just doing second GET to
`/cluster/config/qdevice` made sense
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-09-15 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 10:16 Hannes Laimer
2025-09-12 16:36 ` Thomas Lamprecht
2025-09-15 6:52 ` Hannes Laimer
2025-09-15 10:25 ` Thomas Lamprecht
2025-09-15 10:29 ` Hannes Laimer [this message]
2025-09-15 6:51 ` [pve-devel] [PATCH pve-manager] fixup! " Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b417eea-4ccd-4495-bce5-fe9855ef9350@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox