Re: [pve-devel] [PATCH pve-container 0/3] fix #3711: delete LXC container with missing storage

[Stefan Hrdlicka <s.hrdlicka@proxmox.com>]

On 7/25/22 15:31, Wolfgang Bumiller wrote:
> On Mon, Jul 25, 2022 at 12:40:21PM +0200, Fiona Ebner wrote:
>> Am 20.07.22 um 16:49 schrieb Stefan Hrdlicka:
>>> The patch adds a new option 'force-remove-storage' that stops pct
>>> destory from dying if the storage is not available. This also adds a
>>> menu option for the delete dialog of containers.
>>>
>>
>> VMs are also affected, so we probably want the new option there too.
>> Although for VMs, it is possible to work around the issue by detaching
>> all non-existing disks first.
> 
> Yeah, this is really mostly an issue with the `rootfs`, since you cannot
> detach or remove it, so I think we could have this for VMs just for
> consistency's sake.
> 
>> So slightly related: when detaching a disk and the owner of the volume
>> is different (it also happens when the storage/disk does not exist
>> anymore), we drop the disk for VMs, but we register it as unused for
>> containers. Should we make that consistent?
> 
> Yeah I think consistency makes more sense there as well.

Consistent in that case would be that we also register the disk as 
unused for the VMs as well, instead of dropping it?