From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] plugin: hooks: add explicit returns
Date: Fri, 27 Nov 2020 10:55:36 +0100 [thread overview]
Message-ID: <0ac66c58-ca83-c0ee-325e-e0dbde99f1e7@proxmox.com> (raw)
In-Reply-To: <20201127093544.17667-1-f.ebner@proxmox.com>
On 27.11.20 10:35, Fabian Ebner wrote:
> to avoid returning something unexpected. Finish what
> afeda182566292be15413d9b874720876eac14c9 already started for all the other
> plugins. At least for ZFS's on_add_hook this is necessary (adding a ZFS storage
> currently fails as reported here [0]), but it cannot hurt
> in the other places either as the only hooks we expect to return something
> currently are PBS's on_add_hook and on_update_hook.
>
> [0]: https://forum.proxmox.com/threads/gui-add-zfs-storage-verification-failed-400-config-type-check-object-failed.79734/
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/Storage/CIFSPlugin.pm | 6 ++++++
> PVE/Storage/CephFSPlugin.pm | 4 ++++
> PVE/Storage/LVMPlugin.pm | 2 ++
> PVE/Storage/PBSPlugin.pm | 2 ++
> PVE/Storage/RBDPlugin.pm | 4 ++++
> PVE/Storage/ZFSPoolPlugin.pm | 2 ++
> 6 files changed, 20 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2020-11-27 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 9:35 [pve-devel] " Fabian Ebner
2020-11-27 9:55 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ac66c58-ca83-c0ee-325e-e0dbde99f1e7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox