From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"
Date: Fri, 11 Jun 2021 11:28:54 +0200 [thread overview]
Message-ID: <0ac6276d-0cde-98da-38b8-5d64d4ae4937@proxmox.com> (raw)
In-Reply-To: <20210609135415.3361404-1-a.lauterer@proxmox.com>
On 09.06.21 15:54, Aaron Lauterer wrote:
> https://github.com/zfsonlinux/zfs/issues/8541 is solved and part of
> openzfs 2.0 with [0]. Since we ship only ZFS 2.0 with PVE 7 we should be
> okay to remove our workaround
>
> [0] https://github.com/openzfs/zfs/commit/47c9299fcc9e5fb91d0b1636bfacc03bd3e98439
>
> This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15.
> ---
> PVE/Storage/ZFSPoolPlugin.pm | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
> index 2e2abe3..f719f42 100644
> --- a/PVE/Storage/ZFSPoolPlugin.pm
> +++ b/PVE/Storage/ZFSPoolPlugin.pm
> @@ -313,12 +313,7 @@ sub zfs_get_pool_stats {
>
> sub zfs_create_zvol {
> my ($class, $scfg, $zvol, $size) = @_;
> -
> - # always align size to 1M as workaround until
> - # https://github.com/zfsonlinux/zfs/issues/8541 is solved
> - my $padding = (1024 - $size % 1024) % 1024;
> - $size = $size + $padding;
> -
> +
above + line introduces a trailing whitespace error, please avoid that.
Can you please resend with that fixed and Fabi's T-b tag added?
> my $cmd = ['create'];
>
> push @$cmd, '-s' if $scfg->{sparse};
>
next prev parent reply other threads:[~2021-06-11 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 13:54 Aaron Lauterer
2021-06-10 12:33 ` Fabian Ebner
2021-06-11 9:28 ` Thomas Lamprecht [this message]
2023-06-14 11:28 Aaron Lauterer
2023-06-14 11:38 ` Thomas Lamprecht
2023-06-14 11:44 ` Aaron Lauterer
2023-06-14 12:13 ` Fiona Ebner
2023-06-14 12:26 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ac6276d-0cde-98da-38b8-5d64d4ae4937@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox