From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
hd <h.duerr@proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-i18n 1/1] update German translation
Date: Mon, 9 Oct 2023 12:46:30 +0200 [thread overview]
Message-ID: <0a80e621-7f96-474e-9ed7-573b7c4bd46b@proxmox.com> (raw)
In-Reply-To: <20231009093823.74910-2-h.duerr@proxmox.com>
Hello Hannes,
please configure your git client so that the commit author is your full
name [1]:
git config --global user.name "Firstname Lastname"
Also, this patch is missing the 'Signed-off-by' line. That line is
auto-generated by git if you provide the right flags to `git commit` or
`git format-patch` (e.g. `git commit -s`, maybe create a git alias for that)
Also, for single patches there is no need to send a cover-letter.
If there is anything to be said about the patch that should *not* be
part of the commit message, you can write it under the the '---' marker.
Hope this helps :)
[1] https://pve.proxmox.com/wiki/Developer_Documentation#Using_git
On 10/9/23 11:38, hd wrote:
> ---
^ I mean this marker here.
> de.po | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/de.po b/de.po
> index fea74f1..c647f31 100644
> --- a/de.po
> +++ b/de.po
> @@ -747,9 +747,8 @@ msgid "Authentication mode"
> msgstr "Authentifikationsmodus"
>
> #: proxmox-widget-toolkit/src/panel/SendmailEditPanel.js:111
> -#, fuzzy
> msgid "Author"
> -msgstr "Auth-ID"
> +msgstr "Autor"
>
> #: pmg-gui/js/TFAView.js:60 pve-manager/www/manager6/dc/OptionView.js:241
> #: proxmox-backup/www/config/WebauthnView.js:109
--
- Lukas
next prev parent reply other threads:[~2023-10-09 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 9:38 [pve-devel] [PATCH proxmox-i18n 0/1] " hd
2023-10-09 9:38 ` [pve-devel] [PATCH proxmox-i18n 1/1] " hd
2023-10-09 10:46 ` Lukas Wagner [this message]
2023-10-09 11:11 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a80e621-7f96-474e-9ed7-573b7c4bd46b@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox