* [pve-devel] [PATCH manager] ui: remove local cloud-init live migration limitation
@ 2021-07-27 16:42 Mira Limbeck
2021-07-29 8:43 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Mira Limbeck @ 2021-07-27 16:42 UTC (permalink / raw)
To: pve-devel
With live migration with local cloud-init disk now possible via the CLI
also remove the limitation in the GUI.
Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
---
www/manager6/window/Migrate.js | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 5122e25f..1c23abb3 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -252,15 +252,7 @@ Ext.define('PVE.window.Migrate', {
if (migrateStats.local_disks.length) {
migrateStats.local_disks.forEach(function(disk) {
if (disk.cdrom && disk.cdrom === 1) {
- if (disk.volid.includes('vm-' + vm.get('vmid') + '-cloudinit')) {
- if (migrateStats.running) {
- migration.possible = false;
- migration.preconditions.push({
- text: "Can't live migrate VM with local cloudinit disk, use shared storage instead",
- severity: 'error',
- });
- }
- } else {
+ if (!disk.volid.includes('vm-' + vm.get('vmid') + '-cloudinit')) {
migration.possible = false;
migration.preconditions.push({
text: "Can't migrate VM with local CD/DVD",
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: Re: [PATCH manager] ui: remove local cloud-init live migration limitation
2021-07-27 16:42 [pve-devel] [PATCH manager] ui: remove local cloud-init live migration limitation Mira Limbeck
@ 2021-07-29 8:43 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-07-29 8:43 UTC (permalink / raw)
To: Proxmox VE development discussion, Mira Limbeck
On 27/07/2021 18:42, Mira Limbeck wrote:
> With live migration with local cloud-init disk now possible via the CLI
> also remove the limitation in the GUI.
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> www/manager6/window/Migrate.js | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-29 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 16:42 [pve-devel] [PATCH manager] ui: remove local cloud-init live migration limitation Mira Limbeck
2021-07-29 8:43 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox