Re: [pve-devel] [PATCH pve-guest-common v2 1/1] backup job: remove 'notification-policy' and 'notification-target' options

["Michael Köppl" <m.koeppl@proxmox.com>]

Had a closer look at the implementation, which apart from 2 suggestions
on pve-manager 2/2 looks good.

Quickly had a look at the Backup job details dialog as well and tested
through the various combinations for notification settings. Information
for both the notification system and email notifications are displayed
as expected. I just think the text displayed ("Always use sendmail
to...") could maybe be replaced by something more concise, as noted in
more detail on the respective patch.

Please consider this:
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>

On 6/24/25 13:28, Lukas Wagner wrote:
> Those were only used in the first iteration of the new notification
> stack, which unfortunately hit pvetest too soon. These two keys have no
> effect and were proactively removed by the GUI when changing
> backup job settings.
> 
> With the major update to PVE 9 these can finally be dropped. The pve8to9
> script will gain a check to check for any left-over keys.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> 
> Notes:
>     Changes since v1:
>       - rebase onto latest master
> 
>  src/PVE/VZDump/Common.pm | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
> index 37f5509..902829f 100644
> --- a/src/PVE/VZDump/Common.pm
> +++ b/src/PVE/VZDump/Common.pm
> @@ -266,19 +266,6 @@ my $confdesc = {
>          enum => ['auto', 'legacy-sendmail', 'notification-system'],
>          default => 'auto',
>      },
> -    'notification-policy' => {
> -        type => 'string',
> -        description => "Deprecated: Do not use",
> -        optional => 1,
> -        enum => ['always', 'failure', 'never'],
> -        default => 'always',
> -    },
> -    'notification-target' => {
> -        type => 'string',
> -        format => 'pve-configid',
> -        description => "Deprecated: Do not use",
> -        optional => 1,
> -    },
>      tmpdir => {
>          type => 'string',
>          description => "Store temporary files to specified directory.",



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel