From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH] fix #5869: d/postinst: do not fail if ifreload fails on first install
Date: Thu, 14 Nov 2024 18:37:02 +0100 [thread overview]
Message-ID: <0931bf35-b79d-4225-bebd-8176394de4d1@proxmox.com> (raw)
In-Reply-To: <20241113190113.678807-1-s.ivanov@proxmox.com>
Am 13.11.24 um 20:01 schrieb Stoiko Ivanov:
> erroring out here will not help getting a running network, therefore
> just log a warning.
>
> Tested the original reporters case (running in a debootstrap) with:
> ```
> mmdebstrap \
> --variant=minbase \
> --include=/tmp/ifupdown2_3.2.0-1+pmx10_all.deb \
> --hook-dir=/usr/share/mmdebstrap/hooks/file-mirror-automount \
> bookworm \
> ./bookworm-amd64.tar.zst
> ```
> ran through our install on plain debian guide:
> https://pve.proxmox.com/wiki/Install_Proxmox_VE_on_Debian_12_Bookworm
> with this package in a local repository to check for regressions
>
> adding the reference to the commit that introduced the reload on
> first-install, as this got shifted around a bit and it took me too
> long to see that we did not want to error out here on purpose
>
> Fixes: 86335f3f898c59864a09a3e13b8146c0a0ea079d
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> debian/ifupdown2.postinst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-14 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 19:01 [pve-devel] " Stoiko Ivanov
2024-11-14 17:37 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0931bf35-b79d-4225-bebd-8176394de4d1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox