Re: [pve-devel] [PATCH pve-manager v4 2/3] pve8to9: move checklist to dedicated subcommand

[Friedrich Weber <f.weber@proxmox.com>]

On 07/07/2025 20:46, Thomas Lamprecht wrote:
> Am 07.07.25 um 10:03 schrieb Friedrich Weber:
>> This allows to introduce other subcommands, e.g. for manual actions
>> rqeuired before the upgrade.
>>
>> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
>> ---
>>
>> Notes:
>>     changes since v3:
>>     - rephrase commit message
>>     
>>     new in v3
>>
>>  PVE/CLI/pve8to9.pm | 4 +++-
>>  bin/Makefile       | 2 +-
>>  2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
>> index 45692748..c3fb0b0b 100644
>> --- a/PVE/CLI/pve8to9.pm
>> +++ b/PVE/CLI/pve8to9.pm
>> @@ -1595,6 +1595,8 @@ __PACKAGE__->register_method({
>>      },
>>  });
>>  
>> -our $cmddef = [__PACKAGE__, 'checklist', [], {}];
>> +our $cmddef = {
>> +    checklist => [__PACKAGE__, 'checklist', []],
> 
> we nowadays normally use minus to separate command words, but it
> probably would be fine to just drop the "list" part.
> 
> I'd also strongly prefer making this the default command, if none is
> supplied.
> 

Thanks for looking into this! But since I'm going to move `updatelvm` to
its own script anyway (see the reply to the cover letter), I'll just
drop this patch and keep $cmddef as it is in v5.

>> +};
>>  
>>  1;
>> diff --git a/bin/Makefile b/bin/Makefile
>> index caed0af4..23635a16 100644
>> --- a/bin/Makefile
>> +++ b/bin/Makefile
>> @@ -73,7 +73,7 @@ pve8to9.1:
>>  	 before, and during the upgrade of a Proxmox VE system\n" >> $@.tmp
>>  	printf "Any failure must be addressed before the upgrade, and any warning must be addressed, \
>>  	 or at least carefully evaluated, if a false-positive is suspected\n" >> $@.tmp
>> -	printf ".SH SYNOPSIS\npve8to9 [--full]\n" >> $@.tmp
>> +	printf ".SH SYNOPSIS\npve8to9 checklist [--full]\n" >> $@.tmp
>>  	mv $@.tmp $@
>>  
>>  
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel