From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH] fix #5063: load webgl addon in try block
Date: Mon, 11 Dec 2023 13:39:33 +0100 [thread overview]
Message-ID: <0869533a-9fe0-4646-816f-f9c44e2adc16@proxmox.com> (raw)
In-Reply-To: <20231211101956.2381823-1-d.csapak@proxmox.com>
Am 11/12/2023 um 11:19 schrieb Dominik Csapak:
> since under certain circumstances (e.g. using safari < 16) the addon
> constructor already throws an exception, not only the loading later.
>
> To allow falling back to the canvas renderer, move it into the try block
> after webgl detection.
>
> This should fix the xterm.js console on iOS in chrome and other
> browsers.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> xterm.js/src/main.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-12-11 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 10:19 [pve-devel] " Dominik Csapak
2023-12-11 12:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0869533a-9fe0-4646-816f-f9c44e2adc16@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox