From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Dominic Jäger" <d.jaeger@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit] input panel: Add drawing of layout
Date: Tue, 26 Jan 2021 18:55:20 +0100 [thread overview]
Message-ID: <07c53d23-008e-ba60-a974-1fc25b76e9b9@proxmox.com> (raw)
In-Reply-To: <20201127110812.102886-1-d.jaeger@proxmox.com>
On 27.11.20 12:08, Dominic Jäger wrote:
> The drawing makes clear in a few seconds:
> - what columnT and columnB stand for
> - what additional containers and panels are created
> - to which of those the elements of column1, column2... go to
>
> When you're in the JS debugger and lost overview of where in this
> element hierarchy you are, you can quickly check xtype + layout. Then
> consulting this drawing solves the mistery.
>
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
> IMO it's not that easy/quick to see where everything goes to.
> initComponent is not that short. I actually drew the layout on paper
> to keep an overview while reading it.
>
> There was a drawing already in the commit message of
> 455f5fe input panel: support convenience top column
> so I assumed I'm not the only one who finds such a drawing useful and
> it is easier to find here than in the commit message.
>
> src/panel/InputPanel.js | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2021-01-26 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 11:08 [pve-devel] " Dominic Jäger
2021-01-26 17:55 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07c53d23-008e-ba60-a974-1fc25b76e9b9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox