[pve-devel] [PATCH qemu-server 1/2] config2cmd: make missing EFI disk warning more visible

[pve-devel] [PATCH qemu-server 1/2] config2cmd: make missing EFI disk warning more visible

[Fiona Ebner]

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

(build-)dependency bump for libpve-common-perl >= 7.1-4 needed

 PVE/QemuServer.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c706653b..4e85dd02 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -36,6 +36,7 @@ use PVE::INotify;
 use PVE::JSONSchema qw(get_standard_option parse_property_string);
 use PVE::ProcFSTools;
 use PVE::PBSClient;
+use PVE::RESTEnvironment qw(log_warn);
 use PVE::RPCEnvironment;
 use PVE::Storage;
 use PVE::SysFSTools;
@@ -3611,7 +3612,7 @@ sub config_to_command {
 
 	    $read_only_str = ',readonly=on' if drive_is_read_only($conf, $d);
 	} else {
-	    warn "no efidisk configured! Using temporary efivars disk.\n";
+	    log_warn("no efidisk configured! Using temporary efivars disk.");
 	    $path = "/tmp/$vmid-ovmf.fd";
 	    PVE::Tools::file_copy($ovmf_vars, $path, -s $ovmf_vars);
 	    $format = 'raw';
-- 
2.30.2

[pve-devel] [PATCH qemu-server 2/2] config2cmd: warn when EFI disk is configured, but SeaBIOS is used

[Fiona Ebner]

which can lead to operations like cloning the running VM failing.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 4e85dd02..3d7d70c5 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3633,6 +3633,8 @@ sub config_to_command {
 
 	push @$cmd, '-drive', "if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code";
 	push @$cmd, '-drive', "if=pflash,unit=1$cache,format=$format,id=drive-efidisk0$size_str,file=${path}${read_only_str}";
+    } elsif ($conf->{efidisk0}) {
+	log_warn("EFI disk was not attached, because SeaBIOS is used");
     }
 
     if ($q35) { # tell QEMU to load q35 config early
-- 
2.30.2

Re: [pve-devel] [PATCH qemu-server 2/2] config2cmd: warn when EFI disk is configured, but SeaBIOS is used

[Thomas Lamprecht]

On 31/08/2022 14:46, Fiona Ebner wrote:
> which can lead to operations like cloning the running VM failing.

hmm, could be a bit spammy as warning, but we do not have a level between
info and warning task log; log_notice() could be nice to get sometimes to have
something that isn't as "alarming" as warnings, to avoid normalizing warnings,
which could drown out a more "real" one (not saying this isn't problematic at
all, but there may be some setups that test around with different boot/fw and
want to avoid dropping the efidisk in between).

What about ignoring the efidisk in the clone, and similar affected cases but
warn there instead, while keep the start message here as info log (until we got
a notice log level)?

> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  PVE/QemuServer.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 4e85dd02..3d7d70c5 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -3633,6 +3633,8 @@ sub config_to_command {
>  
>  	push @$cmd, '-drive', "if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code";
>  	push @$cmd, '-drive', "if=pflash,unit=1$cache,format=$format,id=drive-efidisk0$size_str,file=${path}${read_only_str}";
> +    } elsif ($conf->{efidisk0}) {
> +	log_warn("EFI disk was not attached, because SeaBIOS is used");
>      }
>  
>      if ($q35) { # tell QEMU to load q35 config early

[pve-devel] applied: [PATCH qemu-server 1/2] config2cmd: make missing EFI disk warning more visible

[Thomas Lamprecht]

On 31/08/2022 14:46, Fiona Ebner wrote:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> (build-)dependency bump for libpve-common-perl >= 7.1-4 needed
> 
>  PVE/QemuServer.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, thanks!