* [pve-devel] applied: [PATCH] fixes #4874: Raise error for hostname
[not found] <20230803010413.6454-1-info@aminvakil.com>
@ 2023-08-03 8:53 ` Thomas Lamprecht
0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2023-08-03 8:53 UTC (permalink / raw)
To: Amin Vakil, pve-devel
Am 03/08/2023 um 03:04 schrieb Amin Vakil:
> Current error message is not correct because having underscores in domain names are perfectly valid, although it's not acceptable at host names, so it should be changed to "This is not a valid hostname".
>
> https://www.ietf.org/rfc/rfc1123.txt section 2.1 "Host Names and Numbers"
> https://www.rfc-editor.org/rfc/rfc2181#section-11
>
> Signed-off-by: Amin Vakil <info@aminvakil.com>
> ---
> src/Toolkit.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
FYI, I amended the commit as there was still a "wrong" instance of "Host name"
that I replaced with "hostname", and reflowed the commit message so that it uses
70 characters per line as per our commit message style guide:
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-08-03 8:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230803010413.6454-1-info@aminvakil.com>
2023-08-03 8:53 ` [pve-devel] applied: [PATCH] fixes #4874: Raise error for hostname Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox