From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Amin Vakil <info@aminvakil.com>, pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH] fixes #4874: Raise error for hostname
Date: Thu, 3 Aug 2023 10:53:47 +0200 [thread overview]
Message-ID: <0785cff5-888b-45eb-94a2-0b1226160224@proxmox.com> (raw)
In-Reply-To: <20230803010413.6454-1-info@aminvakil.com>
Am 03/08/2023 um 03:04 schrieb Amin Vakil:
> Current error message is not correct because having underscores in domain names are perfectly valid, although it's not acceptable at host names, so it should be changed to "This is not a valid hostname".
>
> https://www.ietf.org/rfc/rfc1123.txt section 2.1 "Host Names and Numbers"
> https://www.rfc-editor.org/rfc/rfc2181#section-11
>
> Signed-off-by: Amin Vakil <info@aminvakil.com>
> ---
> src/Toolkit.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
FYI, I amended the commit as there was still a "wrong" instance of "Host name"
that I replaced with "hostname", and reflowed the commit message so that it uses
70 characters per line as per our commit message style guide:
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
parent reply other threads:[~2023-08-03 8:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230803010413.6454-1-info@aminvakil.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0785cff5-888b-45eb-94a2-0b1226160224@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=info@aminvakil.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox