* [pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages
@ 2023-09-12 12:29 Fiona Ebner
2024-04-11 11:57 ` Fiona Ebner
2024-04-11 19:04 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Fiona Ebner @ 2023-09-12 12:29 UTC (permalink / raw)
To: pve-devel
The one with the backup flag was reported in the community forum:
https://forum.proxmox.com/threads/77254/
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Changes in v2:
* Further improve message as suggested by Sterzy.
pve-zsync | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pve-zsync b/pve-zsync
index 98190b2..de5d46f 100755
--- a/pve-zsync
+++ b/pve-zsync
@@ -949,11 +949,12 @@ sub parse_disks {
$num++;
} else {
- die "ERROR: in path\n";
+ die "unexpected path '$path'\n";
}
}
- die "Vm include no disk on zfs.\n" if !$disks->{0};
+ die "Guest does not include any ZFS volumes (or all are excluded by the backup flag).\n"
+ if !$disks->{0};
return $disks;
}
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages
2023-09-12 12:29 [pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages Fiona Ebner
@ 2024-04-11 11:57 ` Fiona Ebner
2024-04-11 19:04 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Fiona Ebner @ 2024-04-11 11:57 UTC (permalink / raw)
To: pve-devel
Am 12.09.23 um 14:29 schrieb Fiona Ebner:
> The one with the backup flag was reported in the community forum:
> https://forum.proxmox.com/threads/77254/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Ping
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH v2 pve-zsync] parse disks: improve error messages
2023-09-12 12:29 [pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages Fiona Ebner
2024-04-11 11:57 ` Fiona Ebner
@ 2024-04-11 19:04 ` Thomas Lamprecht
2024-04-12 7:07 ` Fiona Ebner
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2024-04-11 19:04 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
On 12/09/2023 14:29, Fiona Ebner wrote:
> The one with the backup flag was reported in the community forum:
> https://forum.proxmox.com/threads/77254/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Changes in v2:
> * Further improve message as suggested by Sterzy.
>
> pve-zsync | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks!
should this immediately bumped or is there some other patches, existing
or short-term planned? Just not that we forget this for too long now
(FWIW, feel free to do the bump yourself if you want).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] applied: [PATCH v2 pve-zsync] parse disks: improve error messages
2024-04-11 19:04 ` [pve-devel] applied: " Thomas Lamprecht
@ 2024-04-12 7:07 ` Fiona Ebner
0 siblings, 0 replies; 4+ messages in thread
From: Fiona Ebner @ 2024-04-12 7:07 UTC (permalink / raw)
To: Thomas Lamprecht, Proxmox VE development discussion
Am 11.04.24 um 21:04 schrieb Thomas Lamprecht:
> On 12/09/2023 14:29, Fiona Ebner wrote:
>> The one with the backup flag was reported in the community forum:
>> https://forum.proxmox.com/threads/77254/
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Changes in v2:
>> * Further improve message as suggested by Sterzy.
>>
>> pve-zsync | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>>
>
> applied, thanks!
>
> should this immediately bumped or is there some other patches, existing
> or short-term planned? Just not that we forget this for too long now
> (FWIW, feel free to do the bump yourself if you want).
I'm not aware of any outstanding patches. Okay, I'll go ahead and bump it.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-12 7:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12 12:29 [pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages Fiona Ebner
2024-04-11 11:57 ` Fiona Ebner
2024-04-11 19:04 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-12 7:07 ` Fiona Ebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox