public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] fix #4333: redirect API handler output to STDERR
Date: Sat, 11 Mar 2023 18:10:24 +0100	[thread overview]
Message-ID: <0758aa38-e363-f3f5-92b1-5198d45d1b94@proxmox.com> (raw)
In-Reply-To: <20230308114709.3391029-1-f.gruenbichler@proxmox.com>

Am 08/03/2023 um 12:47 schrieb Fabian Grünbichler:
> otherwise, print/warn statements by the API endpoint are included in the
> output, which breaks JSON parsing in case of output-format == json*.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     technically a change that might require adapting some scripted calls, although
>     we don't give any guarantees about pvesh output (or task log contents/stdout
>     output of endpoints) I think ;)
>     
>     Suggested-by: reitermarkus (Proxmox Community Forum user)
> 
>  PVE/CLI/pvesh.pm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




      reply	other threads:[~2023-03-11 17:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 11:47 [pve-devel] " Fabian Grünbichler
2023-03-11 17:10 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0758aa38-e363-f3f5-92b1-5198d45d1b94@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal