public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu] PVE backup: improve error when copy-before-write fails for fleecing
Date: Mon, 29 Apr 2024 15:03:10 +0200	[thread overview]
Message-ID: <071338ce-d5be-4bc8-92b0-9c33b78f3e62@proxmox.com> (raw)
In-Reply-To: <20240429125300.86575-1-f.ebner@proxmox.com>

Am 29.04.24 um 14:53 schrieb Fiona Ebner:
> With fleecing, failure for copy-before-write does not fail the guest
> write, but only sets the snapshot error that is associated to the
> copy-before-write filter, making further requests to the snapshot
> access fail with EACCES, which then also fails the job. But that error
> code is not the root cause of why the backup failed, so bubble up the
> original snapshot error instead.
> 
> Reported-by: Friedrich Weber <f.weber@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> Tested-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> 
> Should have a "fixes #5409:" prefix when applied in the parent git

It seems the user does not run into the timeout, but some other issue
https://bugzilla.proxmox.com/show_bug.cgi?id=5409#c15
So while we will better see what the issue is, it's not a fix after all.

> module. Please consider applying this after the update to QEMU 9.0.0.
> Otherwise, I'll have to adapt and re-send that.
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-04-29 13:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29 12:53 Fiona Ebner
2024-04-29 13:03 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=071338ce-d5be-4bc8-92b0-9c33b78f3e62@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal