From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] esxi: use mac address when static, generated and vpx
Date: Tue, 26 Mar 2024 13:06:19 +0100 [thread overview]
Message-ID: <070b28e1-cd94-4027-be42-0cbef4e2abfb@proxmox.com> (raw)
In-Reply-To: <2d2fddcb-c7ab-47ef-956e-71befbdb5d2c@proxmox.com>
sent a v2, unfortunately also one a bit too quickly (with no changes).
please ignore that one :)
On 2024-03-26 12:36, Thomas Lamprecht wrote:
> Am 26/03/2024 um 12:03 schrieb Aaron Lauterer:
>> static -> defined manually
>> generated -> by ESXi
>> vpx -> generated by vCenter
>
> nice!
>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> src/PVE/Storage/ESXiPlugin.pm | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
>> index 77fb6c0..c5ddfea 100644
>> --- a/src/PVE/Storage/ESXiPlugin.pm
>> +++ b/src/PVE/Storage/ESXiPlugin.pm
>> @@ -793,7 +793,10 @@ sub for_each_netdev {
>>
>> my $ty = $dev->{addressType};
>> my $mac = $dev->{address};
>> - if ($ty && fc($ty) eq fc('generated')) {
>> + if ($ty && (fc($ty) eq fc('static')
>> + || fc($ty) eq fc('generated')
>> + || fc($ty) eq fc('vpx') # vCenter generated
>
> To compare the same string to different allowed values in Perl we
> generally prefer to either use a hash map with known OK values as keys,
> or alternatively a regex, e.g.:
>
> if (fc($ty) =~ /^(static|generated|vpx)$/) {
> # ...
> }
>
> If there are only a ~ handful of different option, like here, this is
> still easy to read but avoids some line bloat.
>
> If you want you can send a v2, else I can also change this on applying?
>
>> + )) {
>> $mac = $dev->{generatedAddress} // $mac;
>> }
>>
>
prev parent reply other threads:[~2024-03-26 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 11:03 Aaron Lauterer
2024-03-26 11:36 ` Thomas Lamprecht
2024-03-26 12:06 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=070b28e1-cd94-4027-be42-0cbef4e2abfb@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox