public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Gabriel Goller <g.goller@proxmox.com>
Subject: [pve-devel] applied: [PATCH cluster v3 2/4] add consent-text parameter to datacenter config file
Date: Fri, 4 Apr 2025 19:09:43 +0200	[thread overview]
Message-ID: <0667d02e-c1c7-4bed-8811-d4766785e68a@proxmox.com> (raw)
In-Reply-To: <20241210161158.383142-3-g.goller@proxmox.com>

Am 10.12.24 um 17:11 schrieb Gabriel Goller:
> The consent-text parameter is the base64-encoded content of the optional
> consent-banner which can be displayed before login. The limit is 128kB,
> which is less than the pmxcfs file limit, but still enough to also
> encode images.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  src/PVE/DataCenterConfig.pm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
>

applied, lowered limit to 64 kiB though, no big reason besides
gut-feeling on final apply, we can always increase this if someone
provides a valid usecase, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-04-04 17:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 16:11 [pve-devel] [PATCH cluster/docs/manager/widget-toolkit v3 0/4] fix #5463: add optional Consent Banner on login Gabriel Goller
2024-12-10 16:11 ` [pve-devel] [PATCH manager v3 1/4] show optional consent-banner before login Gabriel Goller
2025-04-04 18:16   ` [pve-devel] applied: " Thomas Lamprecht
2024-12-10 16:11 ` [pve-devel] [PATCH cluster v3 2/4] add consent-text parameter to datacenter config file Gabriel Goller
2025-04-04 17:09   ` Thomas Lamprecht [this message]
2024-12-10 16:11 ` [pve-devel] [PATCH docs v3 3/4] add consent-banner description Gabriel Goller
2025-04-04 18:06   ` [pve-devel] applied: " Thomas Lamprecht
2024-12-10 16:11 ` [pve-devel] [PATCH widget-toolkit v3 4/4] form: set enforceMaxLength on textareafield Gabriel Goller
2025-02-26 17:59   ` Thomas Lamprecht
2025-02-27 12:37     ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0667d02e-c1c7-4bed-8811-d4766785e68a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal