From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] partially-applied-series: [PATCH many v2 00/20] notifications: move template strings to template files; PBS preparations
Date: Wed, 24 Apr 2024 00:31:22 +0200 [thread overview]
Message-ID: <0654214f-1606-4be5-acaa-a2a0beb2638b@proxmox.com> (raw)
In-Reply-To: <20240419141723.377507-1-l.wagner@proxmox.com>
Am 19/04/2024 um 16:17 schrieb Lukas Wagner:
> proxmox:
>
> Lukas Wagner (12):
> notify: switch to file-based templating system
> notify: make api methods take config struct ownership
> notify: convert Option<Vec<T>> -> Vec<T> in config structs
> notify: don't make tests require pve-context
> notify: make the `mail-forwarder` feature depend on proxmox-sys
> notify: cargo.toml: add spaces before curly braces
> notify: give each notification a unique ID
> notify: api: add get_targets
> notify: derive `api` for Deleteable*Property
> notify: derive Deserialize/Serialize for Notification struct
> notify: pbs context: include nodename in default sendmail author
> notify: renderer: add relative-percentage helper from PBS
>
> proxmox-notify/Cargo.toml | 7 +-
> proxmox-notify/examples/render.rs | 63 ------
> proxmox-notify/src/api/gotify.rs | 48 ++---
> proxmox-notify/src/api/matcher.rs | 59 +++--
> proxmox-notify/src/api/mod.rs | 113 ++++++++--
> proxmox-notify/src/api/sendmail.rs | 60 +++---
> proxmox-notify/src/api/smtp.rs | 122 +++++------
> proxmox-notify/src/context/mod.rs | 10 +-
> proxmox-notify/src/context/pbs.rs | 18 +-
> proxmox-notify/src/context/pve.rs | 15 ++
> proxmox-notify/src/context/test.rs | 9 +
> proxmox-notify/src/endpoints/common/mail.rs | 20 +-
> proxmox-notify/src/endpoints/gotify.rs | 12 +-
> proxmox-notify/src/endpoints/sendmail.rs | 34 +--
> proxmox-notify/src/endpoints/smtp.rs | 38 ++--
> proxmox-notify/src/lib.rs | 59 ++---
> proxmox-notify/src/matcher.rs | 71 +++---
> proxmox-notify/src/renderer/html.rs | 14 --
> proxmox-notify/src/renderer/mod.rs | 226 ++++++++------------
> proxmox-notify/src/renderer/plaintext.rs | 39 ----
> 20 files changed, 506 insertions(+), 531 deletions(-)
> delete mode 100644 proxmox-notify/examples/render.rs
>
>
applied above, i.e., the proxmox/proxmox-notify ones.
As talked off-list, for the PVE side I'd like to wait out the next one or two
weeks until the dust of the release settles. Until then, the libpve-rs should
stay on the proxmox-notify 0.3 release, while a hot-fix would be slightly more
work, it's still doable – so I see no real practical issue in having this
divergence between PVE and PBS (where this is all completely new anyway).
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-23 22:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 14:17 [pve-devel] " Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 01/20] notify: switch to file-based templating system Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 02/20] notify: make api methods take config struct ownership Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 03/20] notify: convert Option<Vec<T>> -> Vec<T> in config structs Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 04/20] notify: don't make tests require pve-context Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 05/20] notify: make the `mail-forwarder` feature depend on proxmox-sys Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 06/20] notify: cargo.toml: add spaces before curly braces Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 07/20] notify: give each notification a unique ID Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 08/20] notify: api: add get_targets Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 09/20] notify: derive `api` for Deleteable*Property Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 10/20] notify: derive Deserialize/Serialize for Notification struct Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 11/20] notify: pbs context: include nodename in default sendmail author Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox v2 12/20] notify: renderer: add relative-percentage helper from PBS Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox-perl-rs v2 13/20] notify: use file based notification templates Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox-perl-rs v2 14/20] notify: don't pass config structs by reference Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH proxmox-perl-rs v2 15/20] notify: adapt to Option<Vec<T>> to Vec<T> changes in proxmox_notify Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH cluster v2 16/20] notify: use named template instead of passing template strings Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH pve-ha-manager v2 17/20] env: notify: use named templates " Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH manager v2 18/20] gitignore: ignore any test artifacts Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH manager v2 19/20] tests: remove vzdump_notification test Lukas Wagner
2024-04-19 14:17 ` [pve-devel] [PATCH manager v2 20/20] notifications: use named templates instead of in-code templates Lukas Wagner
2024-04-23 22:31 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0654214f-1606-4be5-acaa-a2a0beb2638b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox