* [pve-devel] [PATCH manager] ui: notification: remove unneeded gettext calls
@ 2023-09-18 8:20 Lukas Wagner
2023-09-18 10:07 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2023-09-18 8:20 UTC (permalink / raw)
To: pve-devel
'mail-to-root' is the name of the default notification target and
should thus not be translated.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/dc/NotificationEvents.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/dc/NotificationEvents.js b/www/manager6/dc/NotificationEvents.js
index 21628204..18816290 100644
--- a/www/manager6/dc/NotificationEvents.js
+++ b/www/manager6/dc/NotificationEvents.js
@@ -40,7 +40,7 @@ Ext.define('PVE.dc.NotificationEventsTargetSelector', {
editable: true,
autoSelect: false,
deleteEmpty: false,
- emptyText: `${Proxmox.Utils.defaultText} (${gettext("mail-to-root")})`,
+ emptyText: `${Proxmox.Utils.defaultText} (mail-to-root)`,
});
Ext.define('PVE.dc.NotificationEvents', {
@@ -126,7 +126,7 @@ Ext.define('PVE.dc.NotificationEvents', {
// Needed since the actual value is always stored in the 'notify' property
let render_value = (store, target_key, mode_key, default_val) => {
let value = store.getById('notify')?.get('value') ?? {};
- let target = value[target_key] ?? gettext('mail-to-root');
+ let target = value[target_key] ?? 'mail-to-root';
let template;
switch (value[mode_key]) {
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: notification: remove unneeded gettext calls
2023-09-18 8:20 [pve-devel] [PATCH manager] ui: notification: remove unneeded gettext calls Lukas Wagner
@ 2023-09-18 10:07 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-09-18 10:07 UTC (permalink / raw)
To: Proxmox VE development discussion, Lukas Wagner
Am 18/09/2023 um 10:20 schrieb Lukas Wagner:
> 'mail-to-root' is the name of the default notification target and
> should thus not be translated.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/dc/NotificationEvents.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-18 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 8:20 [pve-devel] [PATCH manager] ui: notification: remove unneeded gettext calls Lukas Wagner
2023-09-18 10:07 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox