Re: [pve-devel] [PATCH ha-manager v5 06/23] config: delete services from rules if services are deleted from config

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Daniel Kral <d.kral@proxmox.com>
Subject: Re: [pve-devel] [PATCH ha-manager v5 06/23] config: delete services from rules if services are deleted from config
Date: Thu, 31 Jul 2025 06:59:10 +0200	[thread overview]
Message-ID: <05b4b279-bb6f-4977-8519-8e9252c3432d@proxmox.com> (raw)
In-Reply-To: <20250730175957.386674-7-d.kral@proxmox.com>

Am 30.07.25 um 20:00 schrieb Daniel Kral:
> Remove HA resources from rules, where these HA resources are used, if
> they are removed by delete_service_from_config(...), which is called by
> the HA resources' delete API endpoint and possibly external callers,
> e.g. if the HA resource is removed externally.
> 
> If all of the rules' HA resources have been removed, the rule itself
> must be removed as it would result in an erroneous rules config, which
> would become user-visible at the next read and parse of the rules
> config.

Do we the same for groups? Would be worth mentioning for such a case
where we add new infra to replace existing one.

And FWIW (definitively not a blocker), optionally keeping rules would be
nice too, albeit since we got the "ignore" request-state for resources
this probably doesn't really matter that much anymore, as one doesn't
have to remove a service from HA anymore if one wants to temporarily
control the resource directly.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel