[pve-devel] [PATCH storage] mark PBS storages as shared

[pve-devel] [PATCH storage] mark PBS storages as shared

[Fabian Ebner]

Like this, the property will get added when parsing the storage configuration
and PBS storages will correctly show up as shared storages in API results.

AFAICT the only affected PBS operation is free_image via vdisk_free, which will
now be protected by a cluster-wide lock, and that shouldn't hurt.

Another issue this fixes, which is the reason this patch exists, was reported
in the forum[0]. The free space from PBS storages was counted once for each node
that had access to the storage.

[0]: https://forum.proxmox.com/threads/pve-6-3-the-storage-size-was-displayed-incorrectly.83136/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/Storage/Plugin.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
index 57c58a9..d2d8184 100644
--- a/PVE/Storage/Plugin.pm
+++ b/PVE/Storage/Plugin.pm
@@ -37,7 +37,9 @@ our @SHARED_STORAGE = (
     'iscsidirect',
     'glusterfs',
     'zfs',
-    'drbd');
+    'drbd',
+    'pbs',
+);
 
 our $MAX_VOLUMES_PER_GUEST = 1024;
 
-- 
2.20.1

[pve-devel] applied: [PATCH storage] mark PBS storages as shared

[Thomas Lamprecht]

On 27.01.21 13:57, Fabian Ebner wrote:
> Like this, the property will get added when parsing the storage configuration
> and PBS storages will correctly show up as shared storages in API results.
> 
> AFAICT the only affected PBS operation is free_image via vdisk_free, which will
> now be protected by a cluster-wide lock, and that shouldn't hurt.
> 
> Another issue this fixes, which is the reason this patch exists, was reported
> in the forum[0]. The free space from PBS storages was counted once for each node
> that had access to the storage.
> 
> [0]: https://forum.proxmox.com/threads/pve-6-3-the-storage-size-was-displayed-incorrectly.83136/
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/Storage/Plugin.pm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
>

applied, thanks!