public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied:  [PATCH storage] mark PBS storages as shared
Date: Thu, 28 Jan 2021 16:43:33 +0100	[thread overview]
Message-ID: <0585b2aa-d427-dcd4-d806-6a2d1d980cb6@proxmox.com> (raw)
In-Reply-To: <20210127125736.11589-1-f.ebner@proxmox.com>

On 27.01.21 13:57, Fabian Ebner wrote:
> Like this, the property will get added when parsing the storage configuration
> and PBS storages will correctly show up as shared storages in API results.
> 
> AFAICT the only affected PBS operation is free_image via vdisk_free, which will
> now be protected by a cluster-wide lock, and that shouldn't hurt.
> 
> Another issue this fixes, which is the reason this patch exists, was reported
> in the forum[0]. The free space from PBS storages was counted once for each node
> that had access to the storage.
> 
> [0]: https://forum.proxmox.com/threads/pve-6-3-the-storage-size-was-displayed-incorrectly.83136/
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/Storage/Plugin.pm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




      reply	other threads:[~2021-01-28 15:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 12:57 [pve-devel] " Fabian Ebner
2021-01-28 15:43 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0585b2aa-d427-dcd4-d806-6a2d1d980cb6@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal