From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Friedrich Weber <f.weber@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/storage v4 0/5] fix #4997: lvm, lvm-thin: avoid autoactivating LVs
Date: Tue, 8 Jul 2025 12:19:03 +0200 [thread overview]
Message-ID: <0578be87-85c8-463e-a449-55151075bdcc@proxmox.com> (raw)
In-Reply-To: <15453d2c-405a-4a70-b2eb-90ccc410f5b9@proxmox.com>
Am 08.07.25 um 12:16 schrieb Friedrich Weber:
>> [...] and also because we execute commands even
>> if they are not specified completely but if the user supplied string uniquely
>> matches the start of an existing command, like "u" or "update" in this case
>> here would be enough to trigger the command.
> Right, that might be a bit dangerous. But, thinking about it, even if we
> move the `updatelvm` code to a migration helper script, it could still
> ask the user for confirmation before actually making changes (e.g.
> "Disable autoactivation for all guest volumes in VG 'foo'? [Y/n]").
Yes, that seems sensible for the `-t STDOUT` case, which we normally
use as heuristic to check if it's likely an interactive session.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-08 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 8:03 Friedrich Weber
2025-07-07 8:03 ` [pve-devel] [PATCH pve-storage v4 1/2] fix #4997: lvm: create: disable autoactivation for new logical volumes Friedrich Weber
2025-07-07 8:03 ` [pve-devel] [PATCH pve-storage v4 2/2] lvmthin: " Friedrich Weber
2025-07-07 8:03 ` [pve-devel] [PATCH pve-manager v4 1/3] pve8to9: run perltidy Friedrich Weber
2025-07-07 8:03 ` [pve-devel] [PATCH pve-manager v4 2/3] pve8to9: move checklist to dedicated subcommand Friedrich Weber
2025-07-07 18:46 ` Thomas Lamprecht
2025-07-08 10:18 ` Friedrich Weber
2025-07-07 8:03 ` [pve-devel] [PATCH pve-manager v4 3/3] pve8to9: detect and (if requested) disable LVM autoactivation Friedrich Weber
2025-07-08 8:38 ` [pve-devel] [PATCH manager/storage v4 0/5] fix #4997: lvm, lvm-thin: avoid autoactivating LVs Thomas Lamprecht
2025-07-08 10:16 ` Friedrich Weber
2025-07-08 10:19 ` Thomas Lamprecht [this message]
2025-07-09 14:13 ` [pve-devel] superseded: " Friedrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0578be87-85c8-463e-a449-55151075bdcc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox