public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
	"aderumier@odiso.com" <aderumier@odiso.com>,
	"f.ebner@proxmox.com" <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/1] fix #4507 : increase qemu max openfiles limit
Date: Mon, 11 Dec 2023 16:29:19 +0000	[thread overview]
Message-ID: <05582a7f6e3e17166fa9af2e757fc8fffd4d9e1d.camel@groupe-cyllene.com> (raw)
In-Reply-To: <468db986-a957-4216-b4c7-ce9243f9f092@proxmox.com>



>>I thought: can't we instead do this as part of setting up the systemd
>>scope/qemu.slice with LimitNOFILE?

I have tried (see my cover-letter ;), I can't get it work.


"start failed: org.freedesktop.DBus.Error.PropertyReadOnly: Cannot set
property LimitNOFILE, or unknown property.
"

I don't seem to be available in scope object
https://www.freedesktop.org/wiki/Software/systemd/dbus/



>>But that would also affect the swtpm process spawned there :/

Yes, not sure about the impact on other process


 and the systemd.exec man page says:

>            │LimitNOFILE=     │ ulimit -n         │ Number of File
> Descriptors │ Don't use. Be careful when raising the soft limit above
> 1024, since select() cannot │
>            │                 │                  
> │                            │ function with file descriptors above
> 1023 on Linux. Nowadays, the hard limit        │
>            │                 │                  
> │                            │ defaults to 524288, a very high value
> compared to historical defaults. Typically    │
>            │                 │                  
> │                            │ applications should increase their
> soft limit to the hard limit on their own, if    │
>            │                 │                  
> │                            │ they are OK with working with file
> descriptors above 1023, i.e. do not use          │
>            │                 │                  
> │                            │ select(). Note that file descriptors
> are nowadays accounted like any other form of  │
>            │                 │                  
> │                            │ memory, thus there should not be any
> need to lower the hard limit. Use MemoryMax=   │
>            │                 │                  
> │                            │ to control overall service memory use,
> including file descriptor memory.            │

>>So not sure if that's really nicer. This suggests QEMU should raise
>>the
>>limit itself.

Yes, but it don't raise the limit :/ But it's really working with more
than 1024 file descriptor.



  reply	other threads:[~2023-12-11 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-10 14:49 [pve-devel] [PATCH qemu-server 0/1] " Alexandre Derumier
2023-12-10 14:49 ` [pve-devel] [PATCH qemu-server 1/1] fix #4507 : " Alexandre Derumier
2023-12-11  9:46   ` Fiona Ebner
2023-12-11 16:29     ` DERUMIER, Alexandre [this message]
2023-12-12  9:21       ` Fiona Ebner
2023-12-12 11:10         ` DERUMIER, Alexandre
2023-12-12 11:55         ` Thomas Lamprecht
2023-12-12 12:20           ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05582a7f6e3e17166fa9af2e757fc8fffd4d9e1d.camel@groupe-cyllene.com \
    --to=alexandre.derumier@groupe-cyllene.com \
    --cc=aderumier@odiso.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal