public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu] api: qemu: create: default cpu to x86-64-v2-AES
Date: Tue, 22 Oct 2024 15:35:48 +0200	[thread overview]
Message-ID: <053b9820-fe80-4abf-b774-6f8d5e4da368@proxmox.com> (raw)
In-Reply-To: <s8omsiw5o6o.fsf@proxmox.com>

Am 22/10/2024 um 14:15 schrieb Maximiliano Sandoval:
> Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
> 
>> And even then, would this still break restoring backups made before that
>> change?
>> If, this would fall under the changes that need versioning the guest
>> configs. Which naturally is possible but is IMO also not something I'd
>> do lightly, as that's something that might have wide-reaching consequences.
> 
> Would it make more sense to do this only for the CLI tool, and only when creating new VMs?
> 

Hmm, it would feel a bit odd to me to single that specific "mismatch" between
UI default and CLI/schema out but ignore the others, like e.g., the memory
default of 2048, or some dynamic defaults like the OS-type dependent ones.

And while it would have reduced impact, it would be still a breaking change
that might affect peoples automation/scripts.
But if more than just the CPU type would be looked at, and adapted such that
UI and CLI behave more the same, it might be indeed a feasible way to improve
UX slightly on the next major release next year.
Conveying the reason for different defaults and how one can look into which
one will be applied would warrant a short paragraph in the docs then too.
And taking the chance and looking at the CT story on this would be great too,
e.g., like is 512 MB really still a good default for UI/CLI, or unprivileged
vs. privileged.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-10-22 13:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01 14:08 Maximiliano Sandoval
2024-10-02  7:50 ` Shannon Sterz
2024-10-22 11:23 ` Fiona Ebner
2024-10-22 11:35   ` Thomas Lamprecht
2024-10-22 12:15     ` Maximiliano Sandoval
2024-10-22 13:35       ` Thomas Lamprecht [this message]
2024-10-23  9:56         ` Fiona Ebner
2024-10-23 11:06           ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=053b9820-fe80-4abf-b774-6f8d5e4da368@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal