From: Alexander Zeidler <a.zeidler@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/3] pvesubscription: add missing return statement
Date: Wed, 10 Jan 2024 11:59:22 +0100 [thread overview]
Message-ID: <053a69ff0f007d05c2768862634a805ee1ff19d9.camel@proxmox.com> (raw)
In-Reply-To: <ef3c15fd-9771-45ed-8532-bb09dde57212@proxmox.com>
On Wed, 2024-01-10 at 10:29 +0100, Thomas Lamprecht wrote:
> any reason this is relevant you might want to add to the commit
> message here?
to avoid a failing null check and its error message. This confused
users since the activation was successful anyway.
> simple
>
> return;
>
> is slightly preferred for returning undef
I considered using it, but then saw the established use of undef.
Thanks!
next prev parent reply other threads:[~2024-01-10 11:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 14:23 Alexander Zeidler
2024-01-09 14:23 ` [pve-devel] [PATCH manager 2/3] pvesubscription: update set-offline-key description Alexander Zeidler
2024-01-10 9:41 ` Thomas Lamprecht
2024-01-10 11:03 ` Alexander Zeidler
2024-01-10 9:55 ` [pve-devel] applied: " Thomas Lamprecht
2024-01-09 14:23 ` [pve-devel] [PATCH manager 3/3] report: format iptables output for readability Alexander Zeidler
2024-01-10 9:54 ` [pve-devel] applied: " Thomas Lamprecht
2024-01-10 9:29 ` [pve-devel] [PATCH manager 1/3] pvesubscription: add missing return statement Thomas Lamprecht
2024-01-10 10:59 ` Alexander Zeidler [this message]
2024-01-29 9:51 ` Alexander Zeidler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=053a69ff0f007d05c2768862634a805ee1ff19d9.camel@proxmox.com \
--to=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox