public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 container 3/4] lxc: Add `link-down` config to allow setting interfaces as disconnected
Date: Mon, 20 Feb 2023 13:37:37 +0100	[thread overview]
Message-ID: <05242771-1c87-2f30-7fb1-f06092d6a813@proxmox.com> (raw)
In-Reply-To: <20230220123306.nsghztog6ec4mw4p@casey.proxmox.com>

Am 20/02/2023 um 13:33 schrieb Wolfgang Bumiller:
>>> I assumed that, that's why I asked if keeping it that way would help to reuse some
>>> code infra; not sure about how useful it is to keep it for API consumers to keep it
>>> the same as in a quite different API end point,
>> There really is no code-reuse between those two endpoints, so it made
>> sense to me too to rename it.
> It's more about possible code reuse in front-ends rather than in the
> backend though, where a set of common options with common code to
> fill/read/... them can definitely be a thing 😉

fwiw, it won't matter for any of our front ends either, the CT and VM network
API is way to different to share full (edit) panels.

But, for automation tooling that talks with the API it might be quite relevant.

> 
>>> but I see where you come from and don't
>>> insist for going with snake-case, so if you think using the same style here has benefits.
>>> we can ignore the guidance that new params should always use kebab-case.
>> .. but I will rename it back to snake_case for v3, since that seems to
>> be consensus here?
> Given Thomas' plan to rename stuff in the future, I'd say yes, for now.

fine by me, snake_case it is for now, for this specific option.




  reply	other threads:[~2023-02-20 12:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 14:02 [pve-devel] [PATCH v2 container/manager 0/4] fix #3413: Add `Disconnect` option for LXC networks Christoph Heiss
2023-02-15 14:02 ` [pve-devel] [PATCH v2 container 1/4] lxc: Fix some trailing whitespace Christoph Heiss
2023-02-17 14:22   ` Wolfgang Bumiller
2023-02-20 11:13     ` Christoph Heiss
2023-02-15 14:02 ` [pve-devel] [PATCH v2 container 2/4] lxc: Avoid open-coding normal vs SDN-specific tap_plug() Christoph Heiss
2023-02-17 14:34   ` Wolfgang Bumiller
2023-02-20 11:17     ` Christoph Heiss
2023-02-15 14:02 ` [pve-devel] [PATCH v2 container 3/4] lxc: Add `link-down` config to allow setting interfaces as disconnected Christoph Heiss
2023-02-17 14:51   ` Wolfgang Bumiller
2023-02-17 16:38     ` Thomas Lamprecht
2023-02-20 11:51       ` Christoph Heiss
2023-02-20 12:33         ` Wolfgang Bumiller
2023-02-20 12:37           ` Thomas Lamprecht [this message]
2023-02-15 14:02 ` [pve-devel] [PATCH v2 manager 4/4] lxc: Add `Disconnect` option for network interfaces Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05242771-1c87-2f30-7fb1-f06092d6a813@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal