From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server 2/2] api: template: invert lock and fork
Date: Mon, 4 Oct 2021 09:46:54 +0200 [thread overview]
Message-ID: <051465fd-266a-9099-3fc3-eef506bb09c8@proxmox.com> (raw)
In-Reply-To: <20210910074820.1477562-2-f.gruenbichler@proxmox.com>
On 10.09.21 09:48, Fabian Grünbichler wrote:
> like for other API calls, repeat the cheap checks done for early abort
> before forking and without locks after forking and obtaining the lock,
> and only hold the flock in the forked worker instead of across the fork.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> not sure whether we want to switch to the "progress bar -> task viewer"
> thing in the GUI for this endpoint? it's usually instant, except when
> the storage is very slow/overloaded/..
>
> PVE/API2/Qemu.pm | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-10-04 7:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 7:48 [pve-devel] [PATCH qemu-server 1/2] api: return UPID in template call Fabian Grünbichler
2021-09-10 7:48 ` [pve-devel] [PATCH qemu-server 2/2] api: template: invert lock and fork Fabian Grünbichler
2021-10-04 7:46 ` Thomas Lamprecht [this message]
2021-09-10 8:32 ` [pve-devel] [PATCH qemu-server 1/2] api: return UPID in template call Fabian Ebner
2021-09-10 10:03 ` Fabian Grünbichler
2021-09-10 9:26 ` Dominik Csapak
2021-09-10 10:00 ` Thomas Lamprecht
2021-09-10 10:03 ` Fabian Grünbichler
2021-10-04 7:46 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=051465fd-266a-9099-3fc3-eef506bb09c8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox