From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve_flutter_frontend v2] chore: ios: update bundle identifier and display name
Date: Mon, 11 Aug 2025 14:22:14 +0200 [thread overview]
Message-ID: <04e67b66-13a3-4e8a-9c82-dbc5eabba0ca@proxmox.com> (raw)
In-Reply-To: <20250716110219.64029-1-s.shaji@proxmox.com>
On 7/16/25 13:02, Shan Shaji wrote:
> For iOS, the bundle identifier and display name were incorrect. The
> issue was fixed by updating the bundle identifier to
> `com.proxmox.proxmox-ve-companion` and the display name to "Proxmox VE".
>
> The bundle identifer was changed to `com.proxmox.proxmox-ve-companion`
> to match with the bundle identifer defined in the developer console and
> app store connect.
>
> A new `APP_DISPLAY_NAME` variable was defined in the build settings
> and is used for both `CFBundleName` [0] and `CFBundleDisplayName` [1].
>
> The name was not set to "Proxmox VE Companion" because iOS will
> truncate long names on the home screen due to character limits. When
> the above name was set, the name was appearing as "ProxmoxVECo...".
>
> - [0] https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundlename
> - [1] https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundledisplayname
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>
> changes since v1:
> * update commit message with the reason why the bundle
> identifier was changed.
>
> ios/Runner.xcodeproj/project.pbxproj | 9 ++++++---
> ios/Runner/Info.plist | 4 ++--
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-11 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 11:02 [pve-devel] " Shan Shaji
2025-08-11 12:22 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04e67b66-13a3-4e8a-9c82-dbc5eabba0ca@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox