From: Fiona Ebner <f.ebner@proxmox.com>
To: Friedrich Weber <f.weber@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] lvm: avoid warning due to human-readable text in vgs output
Date: Fri, 12 Jan 2024 10:30:35 +0100 [thread overview]
Message-ID: <04539764-6328-40bd-b4bf-d5867eafd735@proxmox.com> (raw)
In-Reply-To: <cfb2ea61-6cb8-47cf-9297-faa3f8bacfbd@proxmox.com>
Am 12.01.24 um 10:09 schrieb Friedrich Weber:
> On 12/01/2024 09:57, Fiona Ebner wrote:
>> Am 11.01.24 um 17:58 schrieb Friedrich Weber:
>>>
>>> [1] https://sourceware.org/git/?p=lvm2.git;a=blob;f=lib/format_text/archive.c;h=5acf0c04a;hb=38e0c7a1#l222
>>>
>>
>>> 222 log_print_unless_silent("Consider pruning %s VG archive with more then %u MiB in %u files (see archiving settings in lvm.conf).",
>>> 223 vgname, (unsigned)sum, archives_size);
>>
>> Can we pass a silent flag when invoking the command instead?
>
> Good point. A quick test shows passing `-q` does not suppress the
> message, but passing `-qq` does. Documentation on `-qq` [1]:
>
>> -q|--quiet ...
>> Suppress output and log messages. Overrides --debug and --verbose.
> Repeat once to also suppress any prompts with answer 'no'.
>
That actually sounds like a single -q should be enough, but oh well...
> Not sure if automatically answering prompts with 'no' might cause
> problems -- I don't think I've ever seen a yes/no prompt by `vgs`
> though. What do you think?
>
Since it's only for listing images, I'd be rather surprised by such a
prompt. And I really hope 'no' would then be the safe option ;)
next prev parent reply other threads:[~2024-01-12 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 16:58 Friedrich Weber
2024-01-12 8:57 ` Fiona Ebner
2024-01-12 9:09 ` Friedrich Weber
2024-01-12 9:30 ` Fiona Ebner [this message]
2024-01-12 9:22 ` Fabian Grünbichler
2024-01-12 10:06 ` Friedrich Weber
2024-01-12 10:28 ` Fabian Grünbichler
2024-01-12 15:11 ` Friedrich Weber
2024-01-12 15:45 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04539764-6328-40bd-b4bf-d5867eafd735@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox