public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Markus Frank <m.frank@proxmox.com>
Subject: [pve-devel] applied: [PATCH container] fix #3917: Ignore fstrim failure in pct fstrim
Date: Wed, 16 Mar 2022 17:05:15 +0100	[thread overview]
Message-ID: <04433052-d7c2-25d6-6a20-d57bd782c93f@proxmox.com> (raw)
In-Reply-To: <20220311115957.230514-1-m.frank@proxmox.com>

On 11.03.22 12:59, Markus Frank wrote:
> With "noerr => 1" the function does not abort, when one of the
> mountpoints is not fstrim compatible like zfs (has its own trim).
> I do not think it is necessary to warn or error, because fstrim 
> tells when something is not trimmable and aborts.
> 
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
>  src/PVE/CLI/pct.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




      reply	other threads:[~2022-03-16 16:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11 11:59 [pve-devel] " Markus Frank
2022-03-16 16:05 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04433052-d7c2-25d6-6a20-d57bd782c93f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal