[pve-devel] [PATCH container] mention file path for ct debug log

[pve-devel] [PATCH container] mention file path for ct debug log

[Oguz Bektas]

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 src/PVE/LXC.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index bae236b..db9a2ee 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2306,7 +2306,10 @@ sub vm_start {
 	monitor_start($monitor_socket, $vmid) if defined($monitor_socket);
 
 	# if debug is requested, print the log it also when the start succeeded
-	print_ct_stderr_log($vmid) if $is_debug;
+	if ($is_debug) {
+	    print_ct_stderr_log($vmid);
+	    print "debug log saved in: /run/pve/ct-$vmid.stderr\n";
+	}
     };
     if (my $err = $@) {
 	unlink $skiplock_flag_fn;
-- 
2.20.1

Re: [pve-devel] [PATCH container] mention file path for ct debug log

[Thomas Lamprecht]

On 25.02.21 11:16, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  src/PVE/LXC.pm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index bae236b..db9a2ee 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -2306,7 +2306,10 @@ sub vm_start {
>  	monitor_start($monitor_socket, $vmid) if defined($monitor_socket);
>  
>  	# if debug is requested, print the log it also when the start succeeded
> -	print_ct_stderr_log($vmid) if $is_debug;
> +	if ($is_debug) {
> +	    print_ct_stderr_log($vmid);
> +	    print "debug log saved in: /run/pve/ct-$vmid.stderr\n";

why though? all of that file is printed so what use is it to see the
path (with just the same content one just gets printed).

Also it's not really saved, this is just in memory. I'd not print that...

> +	}
>      };
>      if (my $err = $@) {
>  	unlink $skiplock_flag_fn;
> 

Re: [pve-devel] [PATCH container] mention file path for ct debug log

[Oguz Bektas]

On Thu, Feb 25, 2021 at 11:58:53AM +0100, Thomas Lamprecht wrote:
> On 25.02.21 11:16, Oguz Bektas wrote:
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> > ---
> >  src/PVE/LXC.pm | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> > index bae236b..db9a2ee 100644
> > --- a/src/PVE/LXC.pm
> > +++ b/src/PVE/LXC.pm
> > @@ -2306,7 +2306,10 @@ sub vm_start {
> >  	monitor_start($monitor_socket, $vmid) if defined($monitor_socket);
> >  
> >  	# if debug is requested, print the log it also when the start succeeded
> > -	print_ct_stderr_log($vmid) if $is_debug;
> > +	if ($is_debug) {
> > +	    print_ct_stderr_log($vmid);
> > +	    print "debug log saved in: /run/pve/ct-$vmid.stderr\n";
> 
> why though? all of that file is printed so what use is it to see the
> path (with just the same content one just gets printed).

hmm i was thinking it'd be easier to attach on the forum threads.

> 
> Also it's not really saved, this is just in memory. I'd not print that...

then maybe we can just save it somewhere and print that?

> 
> > +	}
> >      };
> >      if (my $err = $@) {
> >  	unlink $skiplock_flag_fn;
> > 
> 

Re: [pve-devel] [PATCH container] mention file path for ct debug log

[Thomas Lamprecht]

On 25.02.21 12:01, Oguz Bektas wrote:
> On Thu, Feb 25, 2021 at 11:58:53AM +0100, Thomas Lamprecht wrote:
>> On 25.02.21 11:16, Oguz Bektas wrote:
>>> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
>>> ---
>>>  src/PVE/LXC.pm | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
>>> index bae236b..db9a2ee 100644
>>> --- a/src/PVE/LXC.pm
>>> +++ b/src/PVE/LXC.pm
>>> @@ -2306,7 +2306,10 @@ sub vm_start {
>>>  	monitor_start($monitor_socket, $vmid) if defined($monitor_socket);
>>>  
>>>  	# if debug is requested, print the log it also when the start succeeded
>>> -	print_ct_stderr_log($vmid) if $is_debug;
>>> +	if ($is_debug) {
>>> +	    print_ct_stderr_log($vmid);
>>> +	    print "debug log saved in: /run/pve/ct-$vmid.stderr\n";
>>
>> why though? all of that file is printed so what use is it to see the
>> path (with just the same content one just gets printed).
> 
> hmm i was thinking it'd be easier to attach on the forum threads.
> 

how so? It would only be easier to use that if they had desktop environment
installed and currently use that so that they could prose to the file, but
actually...

>>
>> Also it's not really saved, this is just in memory. I'd not print that...
> 
> then maybe we can just save it somewhere and print that?

... it's already saved in the task log which they just can copy from the
webinterface (and naturally task log file too), seems quite easy to me?

> 
>>
>>> +	}
>>>      };
>>>      if (my $err = $@) {
>>>  	unlink $skiplock_flag_fn;
>>>
>>