From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Zeidler <a.zeidler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 guest-common 4/5] fix #3069: vzdump: schema: add 'pbs-entries-max' property
Date: Thu, 27 Jul 2023 11:32:57 +0200 [thread overview]
Message-ID: <0412c83b-9d08-f35e-dd71-47d1cd3af7cf@proxmox.com> (raw)
In-Reply-To: <20230727083759.19001-5-a.zeidler@proxmox.com>
Am 27.07.23 um 10:37 schrieb Alexander Zeidler:
> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
> index 31e9fdb..ba4a61a 100644
> --- a/src/PVE/VZDump/Common.pm
> +++ b/src/PVE/VZDump/Common.pm
> @@ -88,6 +88,16 @@ PVE::JSONSchema::register_format('backup-performance', {
> default => 16,
> optional => 1,
> },
> + 'pbs-entries-max' => {
> + description => "Applies to container backups sent to PBS. Limits the number of entries "
> + ."allowed in memory at a given time to avoid unintended OOM situations. Increase it to "
> + ."enable backups of folders with a large amount of files. It must be minimum the sum "
Nit: I thought the traversing algorithm we have in the backup client
requires at most that number of elements or did I misunderstand again?
So lower values could work depending on the actual structure, thus
saying "must" is not technically correct. So maybe say "should be at
least the sum" ("at least" sounds more natural than "minimum" IMHO)?
> + ."of all file/folder siblings at each level in its path.",
next prev parent reply other threads:[~2023-07-27 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 8:37 [pve-devel] [PATCH v3 manager/container/guest-common/docs 0/5] fix #3069: add pbs-entries-max to vzdump.conf Alexander Zeidler
2023-07-27 8:37 ` [pve-devel] [PATCH v3 manager/container/guest-common/docs 1/5] api: backup: refactor backup permission check Alexander Zeidler
2023-07-27 8:37 ` [pve-devel] [PATCH v3 manager 2/5] fix #3069: vzdump: add property 'performance: pbs-entries-max=N' Alexander Zeidler
2023-07-27 9:05 ` Fiona Ebner
2023-07-27 8:37 ` [pve-devel] [PATCH v3 container 3/5]: fix #3069: vzdump: add 'pbs-entries-max' parameter Alexander Zeidler
2023-07-27 9:22 ` Fiona Ebner
2023-07-27 8:37 ` [pve-devel] [PATCH v3 guest-common 4/5] fix #3069: vzdump: schema: add 'pbs-entries-max' property Alexander Zeidler
2023-07-27 9:32 ` Fiona Ebner [this message]
2023-07-27 8:37 ` [pve-devel] [PATCH v3 docs 5/5] vzdump: mention new parameter 'pbs-entries-max' Alexander Zeidler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0412c83b-9d08-f35e-dd71-47d1cd3af7cf@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox