From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
"t.lamprecht@proxmox.com" <t.lamprecht@proxmox.com>,
"f.ebner@proxmox.com" <f.ebner@proxmox.com>
Subject: Re: [pve-devel] qemu + tcmalloc for rbd
Date: Wed, 10 Jan 2024 18:29:21 +0000 [thread overview]
Message-ID: <03c20c556994054ecaacf997662c54fab4d1c24d.camel@groupe-cyllene.com> (raw)
In-Reply-To: <2cd67b18-de26-41c3-927a-b8970bbe2336@proxmox.com>
Am 10/01/2024 um 10:12 schrieb Fiona Ebner:
> Am 09.01.24 um 18:02 schrieb DERUMIER, Alexandre:
> > Another way (maybe safer), is to build 2 binary in same package
> > (/usr/bin/kvm-tcmalloc && /usr/bin/kvm), and give option to user
> > to
> > choose it.
> >
>
> If we go for this route, I'd rather have two conflicting packages to
> avoid the redundant space usage for most people. Or if we really want
> to
> support being able to use both on a single system, an add-on kind of
> package with just the second binary.
>>I would like to avoid both, an extra package or an extra binary, as
>>both are a significant overhead for both us to maintain and user to
>>work with.
>>
>>Either tcmalloc works as allocator and is an actual improvement
>>overall,
>>in which case we should unconditionally use it, or it doesn't work,
>>or is
>>no improvement, in which case it makes no sense to expose it.
Yes, I totally understand that. If user have problems (maybe not
related to allocator), it'll need to all tests x2 to debug
(iothreads,..).
>>IME changing allocator is nice for some specific benchmarks, but
>>overall
>>there often even are some regressions in other configurations..
Personnaly, I really see a big difference on real workload with
latencies. (where latencies is really where ceph can be slow)
>>We e.g. tested different allocators extensively when debugging some
>>memory growth during PBS backups, none of the shiny alternatives was
>>really any better, thus we resulted to triggering explicit trims.
yes, I remember of that. I don't use PBS, so I can't comment about
this.
Do you have more information about how to reproduce this ?
I could take some test tcmalloc again with pbs backups.
prev parent reply other threads:[~2024-01-10 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 17:02 DERUMIER, Alexandre
2024-01-10 9:12 ` Fiona Ebner
2024-01-10 9:38 ` DERUMIER, Alexandre
2024-01-10 14:53 ` Thomas Lamprecht
2024-01-10 10:15 ` Thomas Lamprecht
2024-01-10 18:29 ` DERUMIER, Alexandre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03c20c556994054ecaacf997662c54fab4d1c24d.camel@groupe-cyllene.com \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox